Preserve nil-link items across pipeline rebuilds - #175
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CbtimCQAVdGhaEFXsEGKPK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeedMaker.create_pipelineno longer drops items only becauselinkis nil.FeedObjectno longer fabricates placeholder title/link values.SubscriptionTextnow produces documented title-only / URL-only items.Reason
link == nil; a missing field is documenteddata, not an error state (see
doc/REQUIREMENTS.mdsection 8).FilterBatchandFilterJoinproduce legitimate linkless items by design.FeedMaker.create_pipeline's hiddennext if feed.link.nil?silentlydropped those items, breaking composability with downstream link-independent
plugins such as
FilterLimit.FeedObject'shttp://dummy/dummyplaceholder defaults meantSubscriptionText's title-only and URL-only items disagreed with thecontract documented in
doc/PLUGINS.md'sSubscriptionTexttable.Tests
All commands below were run in this environment (Ruby 3.3.6) after
bundle install:bundle exec rspec spec/lib/automatic/feed_maker_spec.rb— 14 examples, 0 failuresbundle exec rspec spec/plugins/subscription/text_spec.rb— 10 examples, 0 failuresbundle exec rspec spec/plugins/filter/batch_spec.rb— 12 examples, 0 failuresbundle exec rspec spec/plugins/filter/image_spec.rb— 3 examples, 0 failuresbundle exec rake spec:lib— 110 examples, 0 failuresbundle exec rake spec:plugins— 290 examples, 0 failuresbundle exec rake spec— 409 examples, 0 failuresgem build automatic.gemspec— succeeded (automatic-26.09.gem)bundle exec ruby -Ilib -e "require 'automatic'"— exit 0bundle exec bin/automatic --version— exit 0, prints26.09bundle exec bin/automatic --help— exit 0Required CI (Ruby 3.3 / 3.4 / 4.0) status will be confirmed once the checks
run on this pull request.
Compatibility
FeedMaker.generate_feed(hash)andFeedMaker.create_pipeline(items)are unchanged.FilterImage's direct behavior (blankinglinkfor non-image URLs) isunchanged; only its documentation wording was corrected.
StoreFile,StorePermalink) are unchanged.do_sort) behavior are unchanged.VERSIONremains26.09; this is a correction that aligns theimplementation with the already-documented pipeline contract.
Version History
Added one coherent entry to the existing unreleased
v26.09section ofdoc/VERSIONS:https://claude.ai/code/session_01CbtimCQAVdGhaEFXsEGKPK
Generated by Claude Code