Repository navigation
build: pin the type-aware lint backend in vite.config.ts and configure Pi for the repo - #755
Open
ian-pascoe wants to merge 2 commits into
Open
ian-pascoe wants to merge 2 commits into
ian-pascoe wants to merge 2 commits into
Conversation
…e Pi for the repo Vite+ sets OXLINT_TSGOLINT_PATH only when it is unset, so agents and worktrees that inherited another checkout's (or a stale) value linted on another tsrs or failed. The root vite.config.ts now assigns it to the tsrs-lint shim. .pi/settings.json runs Pi's formatter and language servers on the project's vp and Effect-patched tsrs.
Owner
Author
Review report — head 510bf56Reviewed Spec: matches the plan. No missing requirements, no scope creep. Fixed: the Windows wording in ADR-0055 and dependencies.md now says oxlint cannot start the Standards: no hard violations. Advisory, not taken:
|
ian-pascoe
requested a deployment
to
preview
November 13, 2026 13:44 — with
GitHub Actions
In progress
Preview deployedURL: https://cloudpid-server-pr-755.ian-g-pascoe.workers.dev Built from 06f4122 (stage This comment updates on each push. |
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs: ADR-0055 → Consequences, the shim's header, dependencies.md's upgrade check (also lint with the variable set to a missing file). Same fix as ian-pascoe/pi-extensions#553.
Evidence
OXLINT_TSGOLINT_PATH=/nonexistent/tsgolint→vp lintfails:Failed to find tsgolint executable. Inherited pi-extensions'tsrs-lint→ lint ran on pi-extensions' tsrs.vp linton a probe reportstypescript(TS2322)andno-floating-promises, and the process tree showsnode …/cloudpid/tools/tsrs-lint-shim/bin/tsgolint.js headless→tsrs --lint headless.OXLINT_TSGOLINT_PATH=/nonexistent vp check vite.config.ts …passes. Both language-server commands answerinitialize.Merge Danger
Door: two-way
Blast Radius: tooling
A shell can no longer choose the lint backend through
OXLINT_TSGOLINT_PATH. Pi picks up.pi/settings.jsonafter/reload, in trusted projects only.Plan
Port pi-extensions 4da05d7 to cloudpid: assign the lint backend in the root
vite.config.ts(to the existing shim), add a project.pi/settings.jsonrunning the formatter and language servers throughpnpm exec(the project's ownvp, and the typecheck's Effect-patched tsrs), and document it.