Repository navigation
test(extensions,mcp): remove the temporary directories tests create - #750
Merged
Merged
Conversation
Preview deployedURL: https://cloudpid-server-pr-750.ian-g-pascoe.workers.dev Built from ef03e02 (stage This comment updates on each push. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/extensions/src/agents-md.test.ts,call-diff.harness.test.ts: each test's Workspace root (agents-md-,call-diff-) is pushed toroots, removed inafterEach.packages/extensions/src/mcp-results.test.ts,mcp-resources.test.ts: the Session'scwd(mcp-results-,mcp-resources-) and thetmp-*dirs pi-durable'sNodeExecutionEnv.createTempDirmakes for Result Spills (tracked by a smallSweptEnvsubclass) are removed inafterEach.packages/mcp/conformance/run.test.ts: theconformance-dir is removed withonTestFinished.mcp-values,bash-routing,coding-tools,environment-skillstests create no temp dirs; unchanged.Evidence
agents-md-, 13call-diff-, 40mcp-*, 15tmp-*spill dirs) + 1 (mcp:conformance-)After: 0 + 0
Merge Danger
Door: two-way
Blast Radius: tests-only