plumb max_guest_log_level through MultiUseSandbox::from_snapshot - #1699
plumb max_guest_log_level through MultiUseSandbox::from_snapshot#1699sethryanrollins wants to merge 1 commit into
max_guest_log_level through MultiUseSandbox::from_snapshot#1699Conversation
|
this looks in the right direction, @sethryanrollins could you sign the DCO or fix the commits and rebase? then we can run CI |
a33ba7e to
be9db37
Compare
|
thanks for your contribution and you interest in hyperlight @sethryanrollins! What I was hoping to do is to address the issue for regular snapshots (taken after init has ran), rather than for these pre-init snapshots (which are not public anyway). It looks like the current state of the PR only addresses pre-init snapshot. Would you be willing to rewrite the PR to deal with post-init snapshots instead? Please let me know if you have any questions as it probably won't be trivial! |
I think this is fine, as we are going to mark the SandboxConfig as deprecated. It will stay as an internal implementation detail. |
be9db37 to
c3d07b0
Compare
|
Rebased the changes onto latest main. |
Plumb max_guest_log_level through MultiUseSandbox::from_snapshot and add changelog entry Signed-off-by: Seth Rollins <sethryanrollins@gmail.com>
c3d07b0 to
6a07fb9
Compare
draft for #1698