Skip to content

chore(deps): group NAPI Cargo updates - #352

Merged
simongdavies merged 1 commit into
mainfrom
simongdavies-ci-failure-investigation
Sep 9, 2026
Merged

chore(deps): group NAPI Cargo updates#352
simongdavies merged 1 commit into
mainfrom
simongdavies-ci-failure-investigation

Conversation

@simongdavies

@simongdavies simongdavies commented Sep 7, 2026

Copy link
Copy Markdown
Member

Summary

Group napi and napi-* Cargo dependency updates into a single Dependabot PR, following the existing hyperlight-* grouping. The group applies across both configured Cargo directories; schedules, cooldowns, and existing groups are unchanged.

Motivation

PR #313 updated napi-derive and napi-derive-backend while leaving napi at 3.12.0. The newer generated bindings require NativeBorrowBarrier and NativeBorrowScope from a newer runtime, causing compilation failures across CI. Updating the runtime and macro crates together avoids that split-update mismatch.

The immediate lockfile fix is being handled separately in #313; this PR changes only .github/dependabot.yml.

Validation

  • Parsed the YAML and confirmed both the new NAPI patterns and existing Hyperlight group.
  • git diff --check passed.
  • Attempted full just check; native prerequisites fail on Windows with linker error LNK1104 while creating the hyperlight_surrogate build-script executable under the long worktree target path. Stopped the remaining build after the prerequisite failures; the full quality gate could not complete locally.

Copilot AI lite review requested due to automatic review settings September 7, 2026 18:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, valid Dependabot grouping update that applies cleanly across the existing Cargo directories without altering schedules or other behavior.

Pull request overview

This PR updates Dependabot configuration to ensure napi and related napi-* Cargo dependencies are grouped into a single Dependabot PR, preventing split updates between the NAPI runtime and derive/macro crates across the repo’s Cargo workspaces.

Changes:

  • Add a new napi Dependabot group with patterns napi and napi-* under the Cargo ecosystem updates.
  • Apply the grouping across both configured Cargo directories via the existing directories: list.
File summaries
File Description
.github/dependabot.yml Adds a napi grouping alongside the existing hyperlight group for Cargo Dependabot updates.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Group napi and napi-* version updates across the existing Cargo directories so runtime and derive crates are updated together.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies
simongdavies force-pushed the simongdavies-ci-failure-investigation branch from a0f758d to a162e4c Compare September 7, 2026 19:09
@simongdavies
simongdavies merged commit cbd6c38 into main Sep 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants