Fix safety documentation of HeaderValue::from_maybe_shared_unchecked() - #873
Open
orium wants to merge 1 commit into
Open
Fix safety documentation of HeaderValue::from_maybe_shared_unchecked()#873orium wants to merge 1 commit into
HeaderValue::from_maybe_shared_unchecked()#873orium wants to merge 1 commit into
Conversation
…()`. The documentation said that non-UTF-8 input causes undefined behavior, which is not the case. Add tests covering non-UTF-8 and invalid header-value sequences.
orium
force-pushed
the
header-value-doc
branch
from
September 10, 2026 14:28
0e126b6 to
5b91ad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation said that non-UTF-8 input causes undefined behavior, which is not the case.
Add tests covering non-UTF-8 and invalid header-value sequences.
Ref #871.