Repository navigation
fix(hyperdx): rename the DocumentDB TLS files into place - #444
Merged
Merged
Conversation
A restarting container could read a partial file when the one-shot overwrote the CA, key or leaf in place. The one-shot writes each file to a .new name before renaming it into place. It renames the key and leaf first and the CA last. The rewrite message printed "a running stack serves the old one" on a fresh volume. The message tells you to restart only if the stack is running. The tests run the one-shot script in a temp directory. A valid pair keeps its sha256 across two runs. If the CA, key or leaf is empty, the one-shot renews all three in the same directories. No .new file is left behind. openssl verify passes. The renew tests fail on main because the one-shot changes the directory inode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A restarting container could read a partial file when the one-shot overwrote the CA, key or leaf in place. The one-shot writes each file to a .new name before renaming it into place. It renames the key and leaf first and the CA last.
The rewrite message printed "a running stack serves the old one" on a fresh volume. The message tells you to restart only if the stack is running.
The tests run the one-shot script in a temp directory. A valid pair keeps its sha256 across two runs.
If the CA, key or leaf is empty, the one-shot renews all three in the same directories. No .new file is left behind. openssl verify passes. The renew tests fail on main because the one-shot changes the directory inode.