Skip to content

com_tools: show admins the tools the forge list drops as unpublished - #1957

Open
denphi wants to merge 1 commit into
hubzero:2.4-mainfrom
denphi:fix/tools-forge-admin-sees-unpublished
Open

denphi wants to merge 1 commit into
hubzero:2.4-mainfrom
denphi:fix/tools-forge-admin-sees-unpublished

Conversation

@denphi

@denphi denphi commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

The forge list at /tools renders a row only when the tool's pipeline state is 7 (published). That state is not a reliable record of whether a tool is live: on a production hub, 74 tools whose resource is published, whose access is public and which have a published tool version are still sitting at state 4 (installed) or 5 (updated), and so never appear. They span the whole history of the hub, from long-standing tools to ones added this year, so this is drift in the pipeline rather than a recent break.

Keep the public list as it is -- ordinary visitors still see published tools only -- and let admins see the ones stalled at installed, updated or approved, so the gap is visible to the people who can act on it. Retired (8) and abandoned (9) stay hidden from everyone, as does anything the existing query already excludes.

Every tool this restores for admins is one the query already returned, so each has a /opt/trac/tools directory and a working wiki link. Tools with no forge directory are still excluded, correctly: the rows link to the tool's Trac wiki, and there would be none to link to.

Before you submit this pull request, please make sure:

  • [] Make sure there are links in the PR to the source JIRA card(s) and hubzero ticket(s)
  • [] Include a brief summary of the issue in your own words
  • [] Include a brief summary of the fix/changed code
  • [] Include a brief summary of your testing. What did you specifically do to investigate that this change has the correct results?
  • [] Indicate if the change needs to be hotfixed to any production hubs before a normal core rollout
  • [] Double check someone is assigned to review the ticket

Thanks!

The forge list at /tools renders a row only when the tool's pipeline
state is 7 (published). That state is not a reliable record of whether a
tool is live: on a production hub, 74 tools whose resource is published,
whose access is public and which have a published tool version are still
sitting at state 4 (installed) or 5 (updated), and so never appear. They
span the whole history of the hub, from long-standing tools to ones added
this year, so this is drift in the pipeline rather than a recent break.

Keep the public list as it is -- ordinary visitors still see published
tools only -- and let admins see the ones stalled at installed, updated or
approved, so the gap is visible to the people who can act on it. Retired
(8) and abandoned (9) stay hidden from everyone, as does anything the
existing query already excludes.

Every tool this restores for admins is one the query already returned, so
each has a /opt/trac/tools directory and a working wiki link. Tools with
no forge directory are still excluded, correctly: the rows link to the
tool's Trac wiki, and there would be none to link to.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@denphi
denphi requested a review from nkissebe as a code owner October 26, 2026 19:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant