Repository navigation
Conversation
getAllTools() left outer joins #__resources to #__tool_version and then groups by v.toolname -- the nullable side of the join. Every type 7 standalone resource with no matching tool version lands in a single v.toolname IS NULL group, r.alias is neither grouped nor functionally dependent on it, and the server returns one arbitrarily chosen alias to stand in for all of them. A second degenerate group forms around v.toolname = '' for resources whose alias is empty. On nanoHUB that surfaced as two entries in /api/tools/listAll that are not tools at all: "mdl" (the alias the server happened to pick out of eight orphaned resources) and "". Sixteen resources in total were being collapsed into those two rows. Group by the alias that is actually selected, make the join inner so the orphan group cannot form, and skip empty aliases. No published tool is lost -- every affected resource is in published state 0, 2 or 4, and the entries are old tool-information stubs and explicit test records. It stays silent because ONLY_FULL_GROUP_BY is off on that server; with it on the query would be rejected outright. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAllTools() left outer joins #__resources to #__tool_version and then groups by v.toolname -- the nullable side of the join. Every type 7 standalone resource with no matching tool version lands in a single v.toolname IS NULL group, r.alias is neither grouped nor functionally dependent on it, and the server returns one arbitrarily chosen alias to stand in for all of them. A second degenerate group forms around v.toolname = '' for resources whose alias is empty.
On nanoHUB that surfaced as two entries in /api/tools/listAll that are not tools at all: "mdl" (the alias the server happened to pick out of eight orphaned resources) and "". Sixteen resources in total were being collapsed into those two rows.
Group by the alias that is actually selected, make the join inner so the orphan group cannot form, and skip empty aliases. No published tool is lost -- every affected resource is in published state 0, 2 or 4, and the entries are old tool-information stubs and explicit test records.
It stays silent because ONLY_FULL_GROUP_BY is off on that server; with it on the query would be rejected outright.
Before you submit this pull request, please make sure:
Thanks!