Repository navigation
Conversation
getToolExportAccess() creates $export_access as a bare stdClass, then every denial branch writes to $export_access->error->message. Under PHP 8 assigning a property on null is an Error, so each of the five refusals -- unknown location, E1 nation, US-only, D1 licence and Purdue-only -- killed the request instead of returning the denial. It only ever bit users who were refused, which is why the tool pages looked healthy for everyone else. Initialise ->error the same way the sibling getToolAccess() already does. The sole caller reads only ->valid, so nothing else changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getToolExportAccess() creates $export_access as a bare stdClass, then every denial branch writes to $export_access->error->message. Under PHP 8 assigning a property on null is an Error, so each of the five refusals -- unknown location, E1 nation, US-only, D1 licence and Purdue-only -- killed the request instead of returning the denial.
It only ever bit users who were refused, which is why the tool pages looked healthy for everyone else.
Initialise ->error the same way the sibling getToolAccess() already does. The sole caller reads only ->valid, so nothing else changes.
Before you submit this pull request, please make sure:
Thanks!