Repository navigation
Wiki default pages: generated macro list, math fixes, accessible search (#1945 + review fixes) - #1950
Merged
Merged
Conversation
The parserdefault plugin's default pages take precedence over com_wiki/default when seeding a wiki, so the accessibility and formatting fixes made only to the com_wiki copies never reached new wikis. Copy them over: MainPage's labelled search form (and the redundant AllPages link removal), Help:WikiMath's block examples, and Help:Processors' table header. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The hand-written list of available macros was incomplete and drifted from the macros actually installed. Render it from the macros themselves instead, in both copies of the default page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sting help pages The generated list now names macros as the parser accepts them (TitleIndex, not Titleindex(args)), includes [[BR]] (handled by the parser itself) and the Group.* macros under macros/group, marks the group-only ones, and leaves out the group base class and the hello-world smoke test. Group.DefaultHomePage's description no longer describes Group.Members. The mixed-delimiters math example is back in one table row: splitting it left a blank, right-aligned label cell on the second row. Default pages are only copied into a wiki when it is created, so the migration applies these fixes to the current version of every stored Help:WikiMacros, Help:WikiMath, Help:Processors and MainPage that still carries the old markup, and leaves edited pages alone where the old markup is gone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1945 (head on the qubeshub fork). Drew's two commits rebased onto 2.4-main, plus one review-fix commit:
[[Macrolist]]now documents every macro with the names the parser accepts (TitleIndex, notTitleindex(args)), includes[[BR]]and theGroup.*macros, marks group-only ones, and hides the group base class and the hello-world test macro.Group.DefaultHomePage's description fixed.Help:WikiMacros,Help:WikiMath,Help:ProcessorsandMainPagepages that still have the old markup — default pages are only seeded at wiki creation, so without this the fixes only reach new wikis. Verified: up() on the pre-PR defaults reproduces the new defaults exactly, is idempotent, and down() restores Processors/MainPage.Not changed:
.sr-onlyon MainPage — it's defined incore/assets/css/actions.css, whichDocumentServiceProvideradds to every HTML page on 2.4-main, so it works under kimera/lucent too.🤖 Generated with Claude Code