Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the main window on macOS destroys xterm while its PTYs remain alive. In the released beta2 app, a 5 MiB producer stopped at parser backpressure during a 65-second closed-window interval; reopening rebuilt the renderer and terminal DOM. Keep the Mac window hidden on close and raise it on Dock activation, including when a plugin window remains open. Quit still destroys the window, and Windows/Linux keep their existing close path.
Separate test commits wait for a new browser document revision, give the successful prompt-acknowledgement scenario its own deadline while retaining short timeout coverage, and inspect renderer splitting in memory without writing temporary bundle files. No tests or runtime platform adapters were removed.
Validation:
The user's installed app and active terminal processes were preserved. Native Intel Mac/Windows/Linux acceptance and physical keyboard behavior are not established by this Apple Silicon run.
This targets the beta2 development branch that selectively incorporated #170;
mainis still at 1.8.4.All seven CI jobs passed at
572dde6: core CI (macOS package/CLI/hidden-terminal/browser, Linux verify, Windows pipe-host, both mascot jobs) and CanvasLink contracts/Android debug. The macOS runner builds the native helper from source with Go before its tests and packaged-app checks.