Skip to content

Correct what a Hookdeck credential is #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leggetter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct what a Hookdeck credential is #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/hookdeck/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,20 @@ export function hookdeckRuntime(options: HookdeckRuntimeOptions): EvalRuntime {
// variable, so the skills delta could not be separated from
// credential disclosure — the run measured our own omission.
//
// One credential type, two projects. Both keys authenticate
// Two project API keys, one per project. Both authenticate
// `api.hookdeck.com` and the CLI; only the Outpost project's key
// reaches the Outpost subdomain, and a key from another project
// gets a `404` there rather than anything that says why (#39).
//
// This said "one credential type" until 1 October, which is wrong
// and had propagated: Hookdeck has organization API keys as well as
// project API keys, and the Outpost API additionally accepts a
// short-lived tenant JWT from `GET /tenants/{tenant_id}/token`
// (`docs/apis/openapi.yaml` carries both `AdminApiKey` and
// `TenantJwt`). What is true of *this harness* is narrower: it
// injects one project API key per project, and which project a key
// belongs to is what decides whether an Outpost call works.
//
// The wording points at the API rather than the CLI deliberately,
// and that is a statement about the pinned version rather than a
// permanent one. Against `HOOKDECK_CLI_VERSION` 2.5.0 the Outpost
Expand Down
Loading