Repository navigation
feat(love): show who is sharing their screen - #11125
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
The screen sharing view only attached the screen share video track and
did not keep the participant that published it, so viewers could not tell
whose screen was shown.
ScreenSharingView now remembers the publishing LiveKit participant along
with the active track, resolves the person from the participant identity
(falling back to the LiveKit participant name) and overlays a
"{name} is sharing the screen" label in the top left corner, styled like
the participant name labels. Adds the ScreenSharedBy string to all love
language files.
Fixes hcengineering#6188
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
MichaelUray
force-pushed
the
feat/love-screen-share-name
branch
from
October 26, 2026 13:26
e6211d5 to
1b9203d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6188
Problem and change
The screen sharing view only attached the screen share video track and
did not keep the participant that published it, so viewers could not tell
whose screen was shown.
ScreenSharingView now remembers the publishing LiveKit participant along
with the active track, resolves the person from the participant identity
(falling back to the LiveKit participant name) and overlays a
"{name} is sharing the screen" label in the top left corner, styled like
the participant name labels. Adds the ScreenSharedBy string to all love
language files.
Tests
No unit test (Svelte wiring around LiveKit events). It needs a configured media server to try: start a meeting with two users and share a screen; the other participant sees "{name} is sharing the screen" in the room view and in the video popup, and the label disappears when sharing stops.