fix: set-game-view-size no longer reports success under the Device Simulator, and --reset removes the size entry it leaves behind

.agents/skills/uloop-set-game-view-size/SKILL.md

@@ -1,17 +1,17 @@
 ---
 name: uloop-set-game-view-size
 toolName: set-game-view-size
-description: "Set or inspect the Unity Game View custom rendering resolution."
+description: "Set, inspect, or reset the Unity Game View custom rendering resolution."
 ---
 
 # uloop set-game-view-size
 
-Set or inspect the Unity Game View custom rendering resolution.
+Set, inspect, or reset the Unity Game View custom rendering resolution.
 
 ## Usage
 
 ```bash
-uloop set-game-view-size [--width <width> --height <height>]
+uloop set-game-view-size [--width <width> --height <height>] [--reset]
 ```
 
 ## Parameters
@@ -20,28 +20,39 @@ uloop set-game-view-size [--width <width> --height <height>]
 |-----------|------|---------|-------------|
 | `--width` | integer | unset | Target Game View rendering width in pixels. Provide with `--height` to change the resolution. |
 | `--height` | integer | unset | Target Game View rendering height in pixels. Provide with `--width` to change the resolution. |
+| `--reset` | flag | - | Removes the `uloop` size entries this tool added from every platform group of the Game View size list, saves the list, and restores the size that was selected before this tool selected its entry. Cannot be combined with `--width` / `--height`. |
 
 ## Output
 
 Returns JSON containing:
 
-- `Success`: Whether the request completed.
-- `PreviousWidth` / `PreviousHeight`: Resolution before the request.
-- `CurrentWidth` / `CurrentHeight`: Resolution after the request.
-- `Changed`: Whether the resolution changed.
+- `Success`: `false` when the Device Simulator (or another non-Game View window) is the Play Mode view and a change or reset was requested, when only one of `--width` / `--height` is given, when a value is not positive, or when `--reset` is combined with a size. Nothing changes in those cases.
+- `View`: Play Mode view after the request: `GameView`, `Simulator`, `None` (no Play Mode view open), or `Other` (a third-party Play Mode view).
+- `PreviousWidth` / `PreviousHeight`: Rendering resolution before the request (`0` when no view was open).
+- `CurrentWidth` / `CurrentHeight`: Rendering resolution after the request.
+- `Changed`: Whether the rendering resolution changed.
+- `SelectedSize`: Name of the entry selected in the Game View size dropdown after the request, e.g. `uloop (1280x720)` or `Free Aspect`. Present when a Game View is showing.
+- `Removed`: Number of `uloop` entries removed. Present with `--reset`.
 - `Message`: Human-readable status.
+- `Warning`: Present after a change; says that the `uloop` entry persists and how to remove it.
 
 ## Examples
 
 ```bash
-# Read the current custom rendering resolution
+# Read the current rendering resolution and the selected size entry
 uloop set-game-view-size
 
-# Set a Full HD custom rendering resolution
+# Pin a Full HD rendering resolution
 uloop set-game-view-size --width 1920 --height 1080
+
+# Remove the uloop entry and restore the previous selection
+uloop set-game-view-size --reset
 ```
 
 ## Notes
 
-- Width and height must be provided together when changing the resolution.
-- The tool uses Unity's public `UnityEditor.PlayModeWindow` API and does not require reflection.
+- Changing the size adds an entry named `uloop (<width>x<height>)` to the Game View size dropdown and selects it; later calls update that one entry, and entries whose name only starts with `uloop` (such as `uloop-phone`) are never touched. Unity saves the list to the user-wide `GameViewSizes.asset` in the Editor preferences folder (macOS: `~/Library/Preferences/Unity/Editor-5.x/`, Windows: `%APPDATA%\Unity\Editor-5.x\Preferences\`), so the entry outlives the Editor session and appears in every project. One entry exists per platform group (Standalone, iOS, Android, ...), so it can sit in more than one group after switching the build target.
+- `--reset` removes those entries from every group and selects the size that was selected before the first change in the current Editor session. That earlier selection is remembered only within the Editor session (it survives a domain reload, not an Editor restart); when it is unknown or no longer exists, the first entry of the group (`Free Aspect`) is selected and `Message` says so. A selection you made yourself in the meantime is kept. The selection is restored only for the current platform group (the one of the active build target); in other groups the entry is removed and Unity keeps or clamps the selection on its own.
+- Under the Device Simulator the Game View size does not apply: a change or `--reset` returns `Success: false` and changes nothing. Run `uloop game-view-mode --to GameView` first, or pick a device with `uloop game-view-mode --device <name>` to change the simulated screen size. Reading without arguments still works and reports the Simulator's rendering size with `View: Simulator`.
+- No Play Mode view open: reading reports `View: None` with `0x0` and opens nothing; a change opens a Game View with the requested size; `--reset` removes the entries and has no selection to restore.
+- Width and height must be provided together and be positive.

.claude/skills/uloop-set-game-view-size/SKILL.md

@@ -1,17 +1,17 @@
 ---
 name: uloop-set-game-view-size
 toolName: set-game-view-size
-description: "Set or inspect the Unity Game View custom rendering resolution."
+description: "Set, inspect, or reset the Unity Game View custom rendering resolution."
 ---
 
 # uloop set-game-view-size
 
-Set or inspect the Unity Game View custom rendering resolution.
+Set, inspect, or reset the Unity Game View custom rendering resolution.
 
 ## Usage
 
 ```bash
-uloop set-game-view-size [--width <width> --height <height>]
+uloop set-game-view-size [--width <width> --height <height>] [--reset]
 ```
 
 ## Parameters
@@ -20,28 +20,39 @@ uloop set-game-view-size [--width <width> --height <height>]
 |-----------|------|---------|-------------|
 | `--width` | integer | unset | Target Game View rendering width in pixels. Provide with `--height` to change the resolution. |
 | `--height` | integer | unset | Target Game View rendering height in pixels. Provide with `--width` to change the resolution. |
+| `--reset` | flag | - | Removes the `uloop` size entries this tool added from every platform group of the Game View size list, saves the list, and restores the size that was selected before this tool selected its entry. Cannot be combined with `--width` / `--height`. |
 
 ## Output
 
 Returns JSON containing:
 
-- `Success`: Whether the request completed.
-- `PreviousWidth` / `PreviousHeight`: Resolution before the request.
-- `CurrentWidth` / `CurrentHeight`: Resolution after the request.
-- `Changed`: Whether the resolution changed.
+- `Success`: `false` when the Device Simulator (or another non-Game View window) is the Play Mode view and a change or reset was requested, when only one of `--width` / `--height` is given, when a value is not positive, or when `--reset` is combined with a size. Nothing changes in those cases.
+- `View`: Play Mode view after the request: `GameView`, `Simulator`, `None` (no Play Mode view open), or `Other` (a third-party Play Mode view).
+- `PreviousWidth` / `PreviousHeight`: Rendering resolution before the request (`0` when no view was open).
+- `CurrentWidth` / `CurrentHeight`: Rendering resolution after the request.
+- `Changed`: Whether the rendering resolution changed.
+- `SelectedSize`: Name of the entry selected in the Game View size dropdown after the request, e.g. `uloop (1280x720)` or `Free Aspect`. Present when a Game View is showing.
+- `Removed`: Number of `uloop` entries removed. Present with `--reset`.
 - `Message`: Human-readable status.
+- `Warning`: Present after a change; says that the `uloop` entry persists and how to remove it.
 
 ## Examples
 
 ```bash
-# Read the current custom rendering resolution
+# Read the current rendering resolution and the selected size entry
 uloop set-game-view-size
 
-# Set a Full HD custom rendering resolution
+# Pin a Full HD rendering resolution
 uloop set-game-view-size --width 1920 --height 1080
+
+# Remove the uloop entry and restore the previous selection
+uloop set-game-view-size --reset
 ```
 
 ## Notes
 
-- Width and height must be provided together when changing the resolution.
-- The tool uses Unity's public `UnityEditor.PlayModeWindow` API and does not require reflection.
+- Changing the size adds an entry named `uloop (<width>x<height>)` to the Game View size dropdown and selects it; later calls update that one entry, and entries whose name only starts with `uloop` (such as `uloop-phone`) are never touched. Unity saves the list to the user-wide `GameViewSizes.asset` in the Editor preferences folder (macOS: `~/Library/Preferences/Unity/Editor-5.x/`, Windows: `%APPDATA%\Unity\Editor-5.x\Preferences\`), so the entry outlives the Editor session and appears in every project. One entry exists per platform group (Standalone, iOS, Android, ...), so it can sit in more than one group after switching the build target.
+- `--reset` removes those entries from every group and selects the size that was selected before the first change in the current Editor session. That earlier selection is remembered only within the Editor session (it survives a domain reload, not an Editor restart); when it is unknown or no longer exists, the first entry of the group (`Free Aspect`) is selected and `Message` says so. A selection you made yourself in the meantime is kept. The selection is restored only for the current platform group (the one of the active build target); in other groups the entry is removed and Unity keeps or clamps the selection on its own.
+- Under the Device Simulator the Game View size does not apply: a change or `--reset` returns `Success: false` and changes nothing. Run `uloop game-view-mode --to GameView` first, or pick a device with `uloop game-view-mode --device <name>` to change the simulated screen size. Reading without arguments still works and reports the Simulator's rendering size with `View: Simulator`.
+- No Play Mode view open: reading reports `View: None` with `0x0` and opens nothing; a change opens a Game View with the requested size; `--reset` removes the entries and has no selection to restore.
+- Width and height must be provided together and be positive.

Assets/Tests/Editor/GameViewSizeListBridgeTests.cs

@@ -0,0 +1,34 @@
+using NUnit.Framework;
+
+using io.github.hatayama.UnityCliLoop.InternalAPIBridge;
+
+namespace io.github.hatayama.UnityCliLoop.Tests.Editor
+{
+    /// <summary>
+    /// Verifies which Game View size entries the size list bridge treats as owned, the only guard in
+    /// front of removing entries from the user-wide size list.
+    /// </summary>
+    public sealed class GameViewSizeListBridgeTests
+    {
+        [Test]
+        public void IsOwnedSize_FixedResolutionWithExactBaseText_IsOwned()
+        {
+            // Verifies a fixed-resolution entry named exactly like the owned base text is claimed.
+            Assert.That(GameViewSizeListBridge.IsOwnedSize("uloop", true, "uloop"), Is.True);
+        }
+
+        [Test]
+        public void IsOwnedSize_BaseTextOnlyStartingWithOwnedName_IsNotOwned()
+        {
+            // Verifies a user entry whose name merely starts with the owned base text is left alone.
+            Assert.That(GameViewSizeListBridge.IsOwnedSize("uloop-phone", true, "uloop"), Is.False);
+        }
+
+        [Test]
+        public void IsOwnedSize_AspectRatioWithExactBaseText_IsNotOwned()
+        {
+            // Verifies an aspect-ratio entry is never claimed, because the tool only adds fixed resolutions.
+            Assert.That(GameViewSizeListBridge.IsOwnedSize("uloop", false, "uloop"), Is.False);
+        }
+    }
+}