fix: announce Christmas Eve, which OffDays lists but never returns

custom_holidays.yaml

@@ -5,6 +5,10 @@ months:
     type: :informal
     regions: [us]
   12:
+  - name: Christmas Eve
+    regions: [us]
+    mday: 24
+    type: :informal
   - name: New Year's Eve
     regions: [us]
     mday: 31
@@ -23,6 +27,11 @@ tests:
       regions: ["us"]
     expect:
       name: "New Year's Eve"
+  - given:
+      date: ['2017-12-24']
+      regions: ["us"]
+    expect:
+      name: "Christmas Eve"
   - given:
       date: ['2017-11-24']
       regions: ["us"]

lib/offbot/off_days.rb

@@ -13,7 +13,7 @@ class OffDays
       "Labor Day",
       "Thanksgiving",
       "Thanksgiving Friday", # in custom_holidays.yaml
-      "Christmas Eve",
+      "Christmas Eve", # in custom_holidays.yaml
       "Christmas Day"
     ].freeze
 

spec/offbot/off_days_spec.rb

@@ -45,12 +45,26 @@
           name: "Thanksgiving Friday",
           regions: array_including(:us)
         },
+        {
+          date: Date.new(2017, 12, 24),
+          name: "Christmas Eve",
+          regions: array_including(:us)
+        },
         {
           date: Date.new(2017, 12, 25),
           name: "Christmas Day",
           regions: array_including(:us)
         }
       ])
     end
+
+    it "returns Christmas Eve, which the holidays gem does not define" do
+      holidays = described_class.new.days_off(Date.new(2026, 12, 21), Date.new(2026, 12, 27))
+
+      expect(holidays.map { |holiday| [holiday[:date], holiday[:name]] }).to eq([
+        [Date.new(2026, 12, 24), "Christmas Eve"],
+        [Date.new(2026, 12, 25), "Christmas Day"]
+      ])
+    end
   end
 end