Repository navigation
feat(helmcapsule): add valuesMode to control Helm reuse-values on upgrade - #1455
Open
leninmehedy wants to merge 1 commit into
Open
leninmehedy wants to merge 1 commit into
leninmehedy wants to merge 1 commit into
Conversation
…rade Add optional spec.valuesMode (Reset, Reuse, ResetThenReuse) so the provisioner can pick the upgrade values behavior by updating the CR. Defaults to Reset, which matches the previous hardcoded behavior. Closes #1454 Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1454
What
Adds optional
spec.valuesModetoHelmCapsule, so the provisioner can choose upgrade values behavior by updating the CR:Reset(default, unchanged behavior):--reset-valuesReuse:--reuse-valuesResetThenReuse:--reset-then-reuse-valuesNotes
status.valuesHash, so it takes effect on the next real upgrade.Reuse, keys removed from the spec persist in the release (Helm semantics). Applied values are visible viahelm get values.Testing
ReleaseOptionstask lintclean;internal/resources/helmandapitests pass