Skip to content

feat: 981: Codec to provide a way to write an item to RandomAccessData at a given offset - #1017

Merged
artemananiev merged 3 commits into
mainfrom
981-M-codec-rad-write
Nov 2, 2026
Merged

feat: 981: Codec to provide a way to write an item to RandomAccessData at a given offset#1017
artemananiev merged 3 commits into
mainfrom
981-M-codec-rad-write

Conversation

@artemananiev

@artemananiev artemananiev commented Oct 30, 2026

Copy link
Copy Markdown
Member

Fix summary:

  • A new method is added to Codec: write(T item, RandomAccessData out, long offset)
  • A number of utility methods are added to ProtoWriterTools for random access writes
  • A few methods are added to runtime classes like Bytes or BufferedData

Testing:

  • Test method generator is improved to verify that sequential and random access writes produce 100% identical bytes

Fixes: #981
Signed-off-by: Artem Ananev artem.ananev@hashgraph.com

@artemananiev
feat: 981: Codec to provide a way to write an item to RandomAccessDat…
2cbd23c 
…a at a given offset

Signed-off-by: Artem Ananev <artem.ananev@hashgraph.com>
@artemananiev artemananiev self-assigned this Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

JUnit Test Report

   545 files  ±0     545 suites  ±0   50s ⏱️ +7s
 1 772 tests ±0   1 768 ✅ ±0   4 💤 ±0  0 ❌ ±0 
11 048 runs  ±0  11 020 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 613f49e. ± Comparison against base commit 3d86e67.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Integration Test Report

    619 files  ±0      619 suites  ±0   40m 58s ⏱️ - 3m 14s
163 748 tests ±0  163 748 ✅ ±0  0 💤 ±0  0 ❌ ±0 
163 992 runs  ±0  163 992 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 613f49e. ± Comparison against base commit 3d86e67.

♻️ This comment has been updated with latest results.

anthony-swirldslabs
anthony-swirldslabs previously approved these changes Oct 30, 2026
View reviewed changes

@anthony-swirldslabs anthony-swirldslabs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Thanks! But I left a few comments.

Comment thread ...rc/main/java/com/hedera/pbj/compiler/impl/generators/protobuf/CodecWriteMethodGenerator.java Resolved
Comment thread pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/TestGenerator.java Resolved
Comment thread pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/buffer/Bytes.java Resolved
Comment thread pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoWriterTools.java Resolved
Comment thread pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoWriterTools.java Resolved
Comment thread pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/buffer/RandomAccessData.java Resolved
@artemananiev
Addressed PR comments
c7033a6 
Signed-off-by: Artem Ananev <artem.ananev@hashgraph.com>
@artemananiev
artemananiev requested review from a team as code owners November 2, 2026 22:33
@artemananiev
Spotless
613f49e 
Signed-off-by: Artem Ananev <artem.ananev@hashgraph.com>
anthony-swirldslabs
anthony-swirldslabs approved these changes Nov 2, 2026
View reviewed changes

@anthony-swirldslabs anthony-swirldslabs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@artemananiev
artemananiev merged commit a98bfb5 into main Nov 2, 2026
18 checks passed
@artemananiev
artemananiev deleted the 981-M-codec-rad-write branch November 2, 2026 22:55
@anthony-swirldslabs anthony-swirldslabs mentioned this pull request Nov 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs approved these changes
@ldintr ldintr Awaiting requested review from ldintr

Assignees

@artemananiev artemananiev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Codec to provide a way to write an item to RandomAccessData at a given offset

2 participants

@artemananiev @anthony-swirldslabs