Skip to content

fix: update record package to resolve missing recordings on macOS 26+ #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmorten merged 4 commits into from
Sep 27, 2026
Merged

fix: update record package to resolve missing recordings on macOS 26+ #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efe3180
feat: update record package
cmorten Sep 27, 2026
c8fb34e
chore: version
cmorten Sep 27, 2026
30b9c66
fix: missing await
cmorten Sep 27, 2026
29996cf
feat: use npm registry
cmorten Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ignore-scripts=true
min-release-age=3
registry=https://registry.npmjs.org
1 change: 1 addition & 0 deletions .yarnrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
registry "https://registry.npmjs.org"
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@guidepup/setup",
"version": "0.29.0",
"version": "0.29.1",
"description": "CLI for configuring environments and install screen reader assets for Guidepup.",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down Expand Up @@ -48,7 +48,7 @@
"typescript": "^5.6.2"
},
"optionalDependencies": {
"@guidepup/record": "^0.1.0"
"@guidepup/record": "^0.2.0"
},
"dependencies": {
"chalk": "^4.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/commands/setup/macOS/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export async function setup({
const osName = platform();
const osVersion = release();

let stopRecording: () => void = () => null;
let stopRecording: () => Promise<void> = () => Promise.resolve(null);

if (macosRecord) {
try {
Expand Down Expand Up @@ -104,6 +104,6 @@ export async function setup({

await waitForAppleScriptControl();
} finally {
stopRecording();
await stopRecording?.();
}
}
Loading
Loading