Repository navigation
Fix TiesToAway rounding below the smallest-subnormal midpoint - #68
Merged
Merged
Conversation
Co-authored-by: awf <128119+awf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix round_float with TiesToAway rounding for small inputs
Fix TiesToAway rounding below the smallest-subnormal midpoint
Oct 18, 2026
awf
approved these changes
Oct 18, 2026
awf
left a comment
awf
left a comment
Collaborator
There was a problem hiding this comment.
Yes, agrees with proposed fix.
awf
marked this pull request as ready for review
October 18, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
round_floatcould round inputs just below half the smallest subnormal away from zero becausedelta + 0.5rounds to1.0in binary64. This disagrees withround_ndarray.delta >= 0.5directly, matching the array implementation.