Aurora aws backup - #2283
Draft
cadmiumcat wants to merge 4 commits into
Draft
Aurora aws backup#2283cadmiumcat wants to merge 4 commits into
cadmiumcat wants to merge 4 commits into
Conversation
We'll need these to be able to "select" them for backing up, assuming we'll select them "by resource" https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/backup_selection
Still need to decide on frequency/lifecycle
We're currently trying this out in integration because it's easy (it doesn't require admin approval). But we may want to store backups somewhere else
We need a KMS key to copy the backups over to another account https://repost.aws/knowledge-center/backup-troubleshoot-cross-account-copy
Pre-Commit reportThis pull request had errors when running pre-commit. Reproduce locally with: Full diff of automatic changesdiff --git a/infra/deployments/forms/backup/backup.tf b/infra/deployments/forms/backup/backup.tf
index b969c970..17ec81ee 100644
--- a/infra/deployments/forms/backup/backup.tf
+++ b/infra/deployments/forms/backup/backup.tf
@@ -153,4 +153,3 @@ resource "aws_iam_role_policy_attachment" "backup_service_role" {
policy_arn = "arn:aws:iam::aws:policy/service-role/AWSBackupServiceRolePolicyForBackup"
role = aws_iam_role.backup_assume_role.name
}
-
diff --git a/infra/deployments/forms/rds/outputs.tf b/infra/deployments/forms/rds/outputs.tf
index a4c08a16..0d7007a7 100644
--- a/infra/deployments/forms/rds/outputs.tf
+++ b/infra/deployments/forms/rds/outputs.tf
@@ -4,4 +4,4 @@ output "forms_admin_aurora_cluster_arn" {
output "forms_runner_aurora_cluster_arn" {
value = module.forms_runner_rds.aurora_cluster_arn
-}
\ No newline at end of file
+}
diff --git a/infra/deployments/integration/account/backup.tf b/infra/deployments/integration/account/backup.tf
index 1aea9860..8685590a 100644
--- a/infra/deployments/integration/account/backup.tf
+++ b/infra/deployments/integration/account/backup.tf
@@ -29,4 +29,4 @@ data "aws_iam_policy_document" "allow_backup_copy" {
resources = [aws_backup_vault.copy.arn]
}
-}
\ No newline at end of file
+}
diff --git a/infra/deployments/integration/account/outputs.tf b/infra/deployments/integration/account/outputs.tf
index 273fb768..9b5de9eb 100644
--- a/infra/deployments/integration/account/outputs.tf
+++ b/infra/deployments/integration/account/outputs.tf
@@ -24,4 +24,4 @@ output "github_oidc_provider_arn" {
output "destination_vault_arn" {
value = aws_backup_vault.copy.arn
-}
\ No newline at end of file
+}
diff --git a/infra/modules/rds/outputs.tf b/infra/modules/rds/outputs.tf
index e45595f1..80a12d05 100644
--- a/infra/modules/rds/outputs.tf
+++ b/infra/modules/rds/outputs.tf
@@ -1,3 +1,3 @@
output "aurora_cluster_arn" {
value = aws_rds_cluster.cluster_aurora_v2.arn
-}
\ No newline at end of file
+}This comment will be updated when code changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,stagingand/orprod)apply-forms-terraform-<environment>pipelines have run successfully