Repository navigation
test: use public-relative vite paths and pin the merged framework and inertia builds - #173
Merged
Merged
Conversation
hwbrzzl
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite.build_directory/vite.hot_fileare leaves insidepublicnow (build,hot), so{{ vite }}resolves the same manifest and hot file as before while the dev-server hot file stops being looked up atpublic/public/hot; the deadinertia.vitemap is gone.goravel/frameworkv1.18.1-0.20261110120158-82c6a43353b4(the #1606 merge) andgoravel/inertiav1.18.1-0.20261110120219-2a36f31baeaa(the Upgrade v1.12.0 #8 merge), withgo mod tidyadvancinggrpc,golang.org/x/exp, andgolang.org/x/toolsto the versions those merged modules require.vite.inputs/vite.assetsmerged with the view-declared entries (deduplicated, sorted), the view scan still covered on its own, andManifestHash()compared against the md5 of the manifest bytes on disk.Why
Framework goravel/framework#1606 re-roots the Vite config paths under
public, mergesvite.inputs/vite.assetsinto whatvite:inputsscans from the views, and exposes the build manifest's hash as the asset version. goravel/inertia#8 drops its own Vite config and delegates{{ vite }}to the framework module. Both are merged now, so this branch pins their merge commits and builds against published versions rather than PR heads — nothing else has to land first.That makes the example the end-to-end proof that the new path semantics, the seeded inputs, and the manifest hash behave as the framework documents: the config keeps serving identical URLs, and the tests fail if a view-only input goes missing or the hash stops tracking a rebuild.