tool test: prepare test python-3.14.8; cl/cltest: TestFromDir support select single dir - #922
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Review summary
Small, well-scoped change that adds single-directory selection to cltest.TestFromDir and reorganizes the C test fixtures (./_testc → ./_testc/clang-c-22.1.8), plus a staged python-3.14.8 fixture. The core logic is correct:
- Single-level
relDir(e.g../_testc,./_testcpp) keeps the originalos.ReadDirbehavior, so existing callers are unaffected. - A multi-level
relDiris correctly reconstructed:fs.NewDirInfo(fname)yields an entry whoseIsDir()istrue, passing thefi.IsDir()filter, andpkgDir = dir + "/" + nameround-trips to the original path. Verified againstqiniu/x v1.18.3.
Security / performance: no issues. The CI push trigger narrowing in .github/workflows/llgo.yml is benign — PRs still run on pull_request: [ "**" ], so merge-gating coverage is unchanged. The new go.sum hashes for goplus/lib v0.5.11 and qiniu/x v1.18.3 match the checksum database.
Inline findings are minor/non-blocking (naming + stale doc comments). A couple of low-priority notes that don't map cleanly to a changed line:
- Mixed path abstractions (
cltest.go): the function buildsdirwithpath.Join(slash-based) but the new branch usesfilepath.Split+string(os.PathSeparator). Harmless on Linux/macOS, but inconsistent with the surrounding slash-based style. - Unreferenced fixture:
tool/_testc/python-3.14.8/adds a module + vendored Python headers, but no test references./_testc/python-3.14.8yet. Looks intentionally staged for a follow-up (commit messages say "prepare") — just confirming it is not expected to be exercised in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.