Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Code Coverage
Files
|
dkhawk
force-pushed
the
feat/zindex-support
branch
2 times, most recently
from
September 18, 2026 23:27
45fdc21 to
b731b02
Compare
…demo Follow-up to #1785 to complete z-index support across the remaining geometry styles (PointStyle, LineStyle), layer mappers (GeoJsonLayer, KmlLayer), and add an interactive demo and visual regression test suite. Key changes: - Model Layer: Add zIndex property (default 0.0f) to PointStyle and LineStyle with KDoc. - Renderer Engine: Propagate style.zIndex to MarkerOptions, AdvancedMarkerOptions, and PolylineOptions in MapViewRenderer. - Layer Bridges: Forward getZIndex() in GeoJsonLayer and inline zIndex in KmlLayer when converting to platform-agnostic models. - Interactive Sample: Add ZIndexDemoActivity showcasing in-place zIndex updates and reset for overlapping polygons, polylines, and markers with Material 3 filled tonal icon buttons and reset action. - Testing: - Unit tests verifying z-index propagation in MapViewRendererTest, GeoJsonLayerObserverTest, and KmlLayerOnMapTest. - On-device visual regression test (ZIndexVisualTest) verifying initial stacking hierarchy, dynamic updates, and reset action.
dkhawk
force-pushed
the
feat/zindex-support
branch
from
September 18, 2026 23:30
b731b02 to
50b78dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1785 to complete z-index support across remaining styles and layer mappers in the
datamodule.Changes
Style.kt:zIndex: Float = 0.0ftoPointStyleandLineStyle(matchingPolygonStyleandGroundOverlayStyle), with KDoc documentation.MapViewRenderer.kt:style.zIndextoMarkerOptionsandAdvancedMarkerOptionsincreateMarkerOptionsandcreateAdvancedMarkerOptions.style.zIndextoPolylineOptionsincreatePolylineOptions.GeoJsonLayer.kt:getZIndex()fromGeoJsonPointStyle,GeoJsonLineStringStyle, andGeoJsonPolygonStylewhen mapping toModelPointStyle,ModelLineStyle, andModelPolygonStyle.KmlLayer.kt:zIndex(andisGeodesic) from inline marker, polyline, and polygon options when converting to platform-agnostic model styles.ZIndexDemoActivity):MapViewRenderer.MainActivityandAndroidManifest.ZIndexVisualTest):BaseVisualTestto verify initial stacking hierarchy and dynamic layering updates on device.MapViewRendererTestforPointStyle.zIndex(legacy markers and advanced markers) andLineStyle.zIndex(polylines).GeoJsonLayerObserverTestverifyingzIndexpropagation for point markers, polylines, and polygons.Verification
./gradlew :data:testDebugUnitTest: Passed (143 unit tests)../gradlew :data:lintDebug: Passed (0 errors)../gradlew :demo:connectedStandardDebugAndroidTest: Passed (2/2 visual tests on Pixel 6).