feat: extract on-device review app and tools to :ApiDemos:reviewer module #2428
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.example.kotlindemos | ||
|
|
||
| import androidx.test.core.app.ActivityScenario | ||
| import androidx.test.espresso.Espresso.onView | ||
| import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu | ||
| import androidx.test.espresso.action.ViewActions.click | ||
| import androidx.test.espresso.assertion.ViewAssertions.matches | ||
| import androidx.test.espresso.matcher.ViewMatchers.isDisplayed | ||
| import androidx.test.espresso.matcher.ViewMatchers.withContentDescription | ||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
| import androidx.test.platform.app.InstrumentationRegistry | ||
| import com.example.common_ui.R | ||
| import com.google.android.material.appbar.MaterialToolbar | ||
| import org.junit.Assert.assertNotNull | ||
| import org.junit.Assert.assertTrue | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| class BasicMapReviewerUiTest { | ||
|
|
||
| @Test | ||
| fun testBasicMapHasReviewerToolbarActions() { | ||
| val scenario = ActivityScenario.launch(BasicMapDemoActivity::class.java) | ||
|
|
||
| scenario.onActivity { activity -> | ||
| val toolbar = activity.findViewById<MaterialToolbar>(R.id.top_bar) | ||
| assertNotNull("Top bar must be present in layout", toolbar) | ||
|
|
||
| // Verify action bar is attached to the toolbar | ||
| val actionBar = activity.supportActionBar | ||
| assertNotNull("SupportActionBar must be attached to MaterialToolbar", actionBar) | ||
|
|
||
| // Verify menu items are present in toolbar | ||
| val menu = toolbar.menu | ||
| assertNotNull("Toolbar menu must not be null", menu) | ||
|
|
||
| val infoItem = menu.findItem(2001) | ||
| assertNotNull("Criteria & Purpose (id 2001) action button must exist in toolbar menu", infoItem) | ||
|
|
||
| val goodJobItem = menu.findItem(2003) | ||
| assertNotNull("Good Job (id 2003) action button must exist in toolbar menu", goodJobItem) | ||
|
|
||
| val wrongItem = menu.findItem(2004) | ||
| assertNotNull("Something's Wrong (id 2004) action button must exist in toolbar menu", wrongItem) | ||
|
Comment on lines
+40
to
+61
Collaborator
There was a problem hiding this comment. Shouldn't the launch intent carry I couldn't run it (no device here), so I may be missing something. Also |
||
| } | ||
|
|
||
| // Verify action icons are displayed and clickable on screen | ||
| onView(withContentDescription("Criteria & Purpose")).check(matches(isDisplayed())) | ||
| onView(withContentDescription("Good Job (Pass)")).check(matches(isDisplayed())) | ||
| onView(withContentDescription("Something's Wrong")).check(matches(isDisplayed())) | ||
|
|
||
| scenario.close() | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this go in its own commit? Adding the whole Compose stack to kotlin-app — plus dropping
kotlin.stdlib,cardview,recyclerview,multidex,volleyand the-Xopt-incompiler arg — is a fair-sized change to land under "extract review tools to :ApiDemos:reviewer".It does all still build, so the removals look safe, I'd just rather they were visible on their own rather than buried in a 12k-line diff.