Skip to content

fix: Drop all trailing user turns when a model turn is invalid in _extract_curated_history #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidLeeGarrett wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −2
Open

fix: Drop all trailing user turns when a model turn is invalid in _extract_curated_history #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ef737e
Drop all trailing user turns when a model turn is invalid in _extract…
DavidLeeGarrett Oct 9, 2026
71065cf
Drop all trailing user turns when a model turn is invalid in _extract…
DavidLeeGarrett Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions google/genai/chats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ def _extract_curated_history(
i += 1
if is_valid:
curated_history.extend(current_output)
elif curated_history:
curated_history.pop()
else:
while curated_history and curated_history[-1].role == 'user':
curated_history.pop()
return curated_history


Expand Down
19 changes: 19 additions & 0 deletions google/genai/tests/chats/test_get_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,25 @@ def test_history_with_valid_and_invalid_model_output():
assert chat.get_history(curated=True) == []


def test_history_with_consecutive_user_inputs_and_invalid_model_turn():
history = [
types.Content(
role='user',
parts=[types.Part.from_text(text='user input 1')],
),
types.Content(
role='user',
parts=[types.Part.from_text(text='user input 2')],
),
types.Content(
role='model',
parts=[], # invalid content
),
]

assert chats._extract_curated_history(history) == []


def test_history_end_with_user_input():
history = [
types.Content(
Expand Down