Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the AcceleratorDaemon class to manage the lifecycle of the Go accelerator daemon subprocess, including spawning the binary, waiting for its Unix domain socket (UDS) to become connectable, and handling teardown. The review feedback identifies several critical robustness and cross-platform compatibility issues: a potential file-locking issue on Windows when cleaning up after a failed spawn, platform-specific errors due to the direct use of socket.AF_UNIX and signal.SIGKILL (which are not supported on all platforms), and a missing cleanup step for self._log_path in _cleanup_tempdir.
Change-Id: I576365629b0f737edc86815208351759d548b734
mutianf
force-pushed
the
accel-01-daemon-subprocess-wrapper
branch
from
September 15, 2026 20:31
da7a290 to
26ed3b9
Compare
Change-Id: I7c218be39c2f62a87e8ca8e924717d6091d97ed7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕