chore: add regeneration presubmit check - #18382
Merged
daniel-sanche merged 5 commits intoSep 15, 2026
Merged
daniel-sanche merged 5 commits into
daniel-sanche merged 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the omni extra dependency (requiring cryptography >= 44.0.0) to the Spanner integration, updating unit and system test configurations, and adds copyright headers to several generated protobuf files. A critical issue was identified in the YAML post-processing configuration, where single-quoted strings are used with escape sequences like \n. Because YAML single-quoted strings do not support escape sequences, this will write literal backslashes and 'n' characters into noxfile.py, breaking its Python syntax. It is recommended to use double-quoted strings with proper escaping instead.
daniel-sanche
changed the title
ohmayr
approved these changes
Sep 15, 2026
daniel-sanche
deleted the
fix_spanner_regeneration_scripts_spanner_18378_fix-regeneration
branch
September 15, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanner is currently creating a diff in the regeneration check, due to changes not present in the post-processing script, and missing headers
This PR adds a pre-submit to catch these issues before merge, and fixes the spanner issue
Fixes #18378