Skip to content

fix: disambiguate google-cloud-bigquery to_dataframe usage from pandas-gbq in ua. - #18369

Merged
tswast merged 6 commits into
mainfrom
b540939659-user-agent
Sep 16, 2026
Merged

tswast merged 6 commits into
mainfrom
b540939659-user-agent

Conversation

@tswast

@tswast tswast commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

For internal issue b/540939659 and a follow-up to #18364

🦕

@tswast
tswast requested review from a team as code owners September 14, 2026 21:39
@tswast
tswast requested review from shuoweil and removed request for a team September 14, 2026 21:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery client to include the google-cloud-bigquery version as a legacy identifier in the user agent string for to_dataframe and to_arrow operations, and adds corresponding unit tests. The review feedback suggests aliasing the imported version module to bq_version to avoid potential shadowing conflicts, and removing redundant local imports of the sys module within several test functions in test_table.py.

Comment thread packages/google-cloud-bigquery/google/cloud/bigquery/client.py Outdated
Comment thread packages/google-cloud-bigquery/google/cloud/bigquery/client.py Outdated
Comment thread packages/google-cloud-bigquery/tests/unit/test_table.py Outdated
Comment thread packages/google-cloud-bigquery/tests/unit/test_table.py Outdated
Comment thread packages/google-cloud-bigquery/tests/unit/test_table.py Outdated
Comment thread packages/google-cloud-bigquery/tests/unit/test_table.py Outdated
@tswast
tswast merged commit 0d7d59c into main Sep 16, 2026
47 checks passed
@tswast
tswast deleted the b540939659-user-agent branch September 16, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants