chore(bigquery): add Arrow performance benchmarks to QueryBenchmark - #14416
jinseopkim0 wants to merge 2 commits into
Conversation
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two new benchmark methods, queryWithArrowRowBased and queryWithArrowZeroCopy, to QueryBenchmark.java to measure Arrow-based query performance. The reviewer recommends explicitly setting the query results format to ARROW in the zero-copy benchmark to ensure a fair and consistent comparison with the row-based benchmark.
There was a problem hiding this comment.
Code Review
This pull request introduces two new benchmark methods, queryWithArrowRowBased and queryWithArrowZeroCopy, to QueryBenchmark.java for measuring BigQuery query performance with Arrow format. Feedback on the changes suggests explicitly setting the query results format to ARROW in the queryWithArrowZeroCopy configuration to ensure the query is executed in the correct format.
…ArrowZeroCopy benchmark
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces two new benchmark methods, queryWithArrowRowBased and queryWithArrowZeroCopy, to QueryBenchmark.java to evaluate the performance of querying with the Arrow format using row-based and zero-copy mechanisms. There are no review comments, and I have no feedback to provide.
1 participant
Add performance benchmarks for row-based (queryWithArrowRowBased) and zero-copy (queryWithArrowZeroCopy) Arrow query execution paths in QueryBenchmark, fulfilling the design document testing and benchmarking strategy.