Repository navigation
Conversation
This has the 'tools' project depending on core, with the purpose being that CLI-unrelated changes won't require recompilation of the CLI-related code (and the associated Dagger generation that can be fairly heavy). This moves creation of the nomulus tool JARfile from core/ to tools/, but the registryTool task remains the same. We also update the deployment process to copy that jarfile from the new location.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the 'tools' project depending on core, with the purpose being that CLI-unrelated changes won't require recompilation of the CLI-related code (and the associated Dagger generation that can be fairly heavy).
This moves creation of the nomulus tool JARfile from core/ to tools/, but the registryTool task remains the same. We also update the deployment process to copy that jarfile from the new location.
This change is