Repository navigation
Conversation
gbrodman
requested changes
Oct 7, 2026
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on CydeWeys).
release/db-object-updater/sync_db_objects.sh line 42 at r1 (raw file):
if [[ -e "${FILE}" ]]; then echo "${FILE}" if ! java -jar /nomulus.jar -e "${nomulus_env}" \
we should capture the output here and only attempt the create-list fallback when the output tells us that the list doesn't exist
for other failures, just error out with that failure
release/db-object-updater/sync_db_objects.sh line 53 at r1 (raw file):
echo "update_premium_list failed for ${FILE}, attempting" \ "create_premium_list fallback with currency ${CURRENCY:-USD}..." java -jar /nomulus.jar -e "${nomulus_env}" \
what happens if this fails? i worry we'd be swallowing any failure
CydeWeys
force-pushed
the
sync-new-lists
branch
from
October 9, 2026 17:15
62d9717 to
826bc64
Compare
Add --upsert (-u) flag to UpdatePremiumListCommand and UpdateReservedListCommand so that missing premium and reserved lists are created automatically when --upsert is specified, while still failing when --upsert is omitted and the list does not exist. Allow CurrencyUnit to be nullable in PremiumListUtils.parseToPremiumList() so that PremiumList.createFromLine() infers the currency unit from the input lines when currency is unset, and use this in UpdatePremiumListCommand when creating a new list via --upsert. Also fix the mixed-currency example in config/files/premium/example.txt. Also propagate exceptions from CreateOrUpdatePremiumListCommand.execute() and CreateOrUpdateReservedListCommand.execute() instead of catching and swallowing Throwable, and validate non-empty and parseable input data in CreatePremiumListCommand.prompt(). Add comprehensive unit tests across PremiumListUtilsTest and the create/update list command test suites. BUG=http://b/569977604
Update release/db-object-updater/sync_db_objects.sh to pass --upsert when running update_premium_list or update_reserved_list so newly added lists are created automatically, and quote directory and file path variables while skipping non-existent glob expansions. Also reorder release/cloudbuild-sync-db-objects.yaml so that update_premium_list and update_reserved_list run before configure_tld, ensuring newly created lists exist in the database before TLD configurations reference them. Add unit tests for sync_db_objects.sh in SyncDbObjectsTest. BUG=http://b/569977604
CydeWeys
force-pushed
the
sync-new-lists
branch
from
October 9, 2026 17:23
826bc64 to
a902fe1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
release/db-object-updater/sync_db_objects.shto pass--upsertwhen runningupdate_premium_listorupdate_reserved_listso newly added lists are created automatically without shell fallback or currency parsing.Also reorder
release/cloudbuild-sync-db-objects.yamlso that premium and reserved lists are synced beforeconfigure_tldruns, ensuring newly created lists exist in the database before TLD configurations reference them, and add unit tests forsync_db_objects.shinSyncDbObjectsTest.Note: This PR is stacked on #3248 (
update-list-upsert) and should be merged and deployed only after #3248 is deployed to production.BUG=http://b/569977604
This change is