Skip to content

Improve pr-polisher formatting and output checks - #3243

Merged
CydeWeys merged 1 commit into
google:masterfrom
CydeWeys:fix-pr-polisher-script
Oct 1, 2026
Merged

CydeWeys merged 1 commit into
google:masterfrom
CydeWeys:fix-pr-polisher-script

Conversation

@CydeWeys

@CydeWeys CydeWeys commented Oct 1, 2026 •

Copy link
Copy Markdown
Member
  1. Sync the local refs/remotes/origin/master tracking ref to refs/remotes/upstream/master before running javaIncrementalFormatCheck so google-java-format-git-diff.sh only evaluates the current branch's diff in fork-based workflows.
  2. Clean up the temporary gjf.out file generated by javaIncrementalFormatCheck and run check_workspace_clean() after formatting checks.
  3. Fix broken ANSI color escape sequences in check_diff.py.

This change is Reviewable

@CydeWeys
CydeWeys requested a review from jicelhay October 1, 2026 18:44
Comment thread .gemini/skills/pr-polisher/scripts/check_diff.py Fixed
@CydeWeys
CydeWeys enabled auto-merge October 1, 2026 18:44
1. Sync the local refs/remotes/origin/master tracking ref to
   refs/remotes/upstream/master before running javaIncrementalFormatCheck
   so google-java-format-git-diff.sh only evaluates the current branch's
   diff in fork-based workflows.
2. Clean up the temporary gjf.out file generated by
   javaIncrementalFormatCheck and run check_workspace_clean() after
   formatting checks.
3. Fix broken ANSI color escape sequences in check_diff.py.
@CydeWeys
CydeWeys force-pushed the fix-pr-polisher-script branch from 2687e04 to 141b7ad Compare October 1, 2026 19:22

@jicelhay jicelhay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jicelhay made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on CydeWeys).

@CydeWeys
CydeWeys added this pull request to the merge queue Oct 1, 2026
Merged via the queue into google:master with commit a6bb0a4 Oct 1, 2026
15 of 16 checks passed
@CydeWeys
CydeWeys deleted the fix-pr-polisher-script branch October 1, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants