Repository navigation
feat(secops): add get_stats aggregation tool with unit tests - #339
Merged
dandye merged 3 commits intoNov 10, 2026
Merged
Conversation
jllangley
force-pushed
the
secops__add-stats-aggregation-tool
branch
from
November 10, 2026 00:33
363976d to
d4f509b
Compare
Address review feedback for Optional annotations, lazy logging, legacy param removal, YARA-L test queries, and docs that match Chronicle column naming.
…nd refine get_stats docs
dandye
approved these changes
Nov 10, 2026
dandye
left a comment
dandye
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for addressing all of the review items and re-signing the commits, @jllangley. Pushed a small maintainer merge commit (1179eb1) to resolve the conflict with main in server/secops/tests/test_secops_tools_unit.py, update the metadata.event_type test filter to EVENTTYPE_UNSPECIFIED for YARA-L 2.0 enum validation, and align the docstring Example 2 and time-bucket notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes and references #246.
Closes #336