Skip to content

Show a message instead of an endless spinner for missing submission p… - #2640

Merged
rfontanarosa merged 5 commits into
masterfrom
rfontanarosa/2619/infinite-spinner-for-submission-photos-that-were-never-uploaded
Oct 30, 2026
Merged

rfontanarosa merged 5 commits into
masterfrom
rfontanarosa/2619/infinite-spinner-for-submission-photos-that-were-never-uploaded

Conversation

@rfontanarosa

@rfontanarosa rfontanarosa commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

closes #2619

Registrazione.schermo.2026-10-23.alle.12.31.26.mov

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'photo unavailable' state for submission photos, including UI updates, localized messaging, and logic in the component to handle failed image downloads. The review feedback suggests using Angular's onCleanup within the effect function as a more idiomatic approach to manage asynchronous operations and prevent potential race conditions.

@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.22%. Comparing base (a3e8936) to head (160eec7).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2640   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files         121      121           
  Lines        3031     3031           
  Branches      463      463           
=======================================
  Hits         1977     1977           
  Misses        986      986           
  Partials       68       68           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfontanarosa rfontanarosa self-assigned this Oct 23, 2026
@rfontanarosa
rfontanarosa requested a review from gino-m October 29, 2026 13:03
@gino-m

gino-m commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Hi @rfontanarosa, we currently don't have anyone maintaining this fork. Please submit your changes to the openforis fork for now.

@rfontanarosa
rfontanarosa merged commit 4b540a0 into master Oct 30, 2026
11 checks passed
@rfontanarosa
rfontanarosa deleted the rfontanarosa/2619/infinite-spinner-for-submission-photos-that-were-never-uploaded branch October 30, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite spinner for submission photos that were never uploaded

3 participants