Repository navigation
Show a message instead of an endless spinner for missing submission p… - #2640
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a 'photo unavailable' state for submission photos, including UI updates, localized messaging, and logic in the component to handle failed image downloads. The review feedback suggests using Angular's onCleanup within the effect function as a more idiomatic approach to manage asynchronous operations and prevent potential race conditions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2640 +/- ##
=======================================
Coverage 65.22% 65.22%
=======================================
Files 121 121
Lines 3031 3031
Branches 463 463
=======================================
Hits 1977 1977
Misses 986 986
Partials 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…mission-photos-that-were-never-uploaded
…mission-photos-that-were-never-uploaded
|
Hi @rfontanarosa, we currently don't have anyone maintaining this fork. Please submit your changes to the openforis fork for now. |
…mission-photos-that-were-never-uploaded
closes #2619
Registrazione.schermo.2026-10-23.alle.12.31.26.mov