Skip to content

Virtualize the LOI list under each job - #2627

Merged
rfontanarosa merged 7 commits into
masterfrom
rfontanarosa/2233/add-support-for-rendering-10k-polygons-6
Oct 30, 2026
Merged

rfontanarosa merged 7 commits into
masterfrom
rfontanarosa/2233/add-support-for-rendering-10k-polygons-6

Conversation

@rfontanarosa

@rfontanarosa rfontanarosa commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Expanding a job rendered a button and an SVG icon for every one of its LOIs, so a job with thousands of them was slow to open and to scroll.

Render the list in a cdk-virtual-scroll-viewport, so only the visible rows are in the DOM regardless of how many LOIs the job has. The list fits its rows up to 12, then scrolls. When the selected LOI is not visible (e.g. picked on the map), the list scrolls to it.

Rows now have a fixed height, so long LOI names are truncated with an ellipsis instead of wrapping; the full name is available as a tooltip.

part of #2233

Screenshot 2026-10-13 alle 15 57 26

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@rfontanarosa
rfontanarosa requested a review from gino-m October 13, 2026 13:59
@codecov-commenter

codecov-commenter commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.43%. Comparing base (4b540a0) to head (7801325).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ts/shared/job-list-item/job-list-item.component.ts 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2627      +/-   ##
==========================================
+ Coverage   65.22%   65.43%   +0.20%     
==========================================
  Files         121      121              
  Lines        3031     3052      +21     
  Branches      463      467       +4     
==========================================
+ Hits         1977     1997      +20     
- Misses        986      987       +1     
  Partials       68       68              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfontanarosa

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Angular CDK's virtual scrolling into the JobListItemComponent to optimize performance when rendering large lists of Locations of Interest (LOIs). It also updates the associated styles to handle text overflow with ellipsis and adapts the unit tests to support asynchronous virtual scroll rendering. The review feedback suggests refining the scroll-to-index logic to use precise pixel bounds to avoid partial visibility bugs, and adding tooltips to the collapsed LOI buttons to improve accessibility and usability.

@rfontanarosa
rfontanarosa merged commit 3ea0be2 into master Oct 30, 2026
9 checks passed
@rfontanarosa
rfontanarosa deleted the rfontanarosa/2233/add-support-for-rendering-10k-polygons-6 branch October 30, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants