Repository navigation
Conversation
…nsService Co-authored-by: gino-m <228050+gino-m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules Please fix failing tests and try again. |
I'm looking into the failing tests. I notice that trying to use |
Co-authored-by: gino-m <228050+gino-m@users.noreply.github.com>
Co-authored-by: gino-m <228050+gino-m@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
+ Coverage 65.43% 65.56% +0.13%
==========================================
Files 121 122 +1
Lines 3052 3058 +6
Branches 467 467
==========================================
+ Hits 1997 2005 +8
+ Misses 987 985 -2
Partials 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors access to Cloud Functions by extracting the logic from AuthService into a new CloudFunctionsService, updating the corresponding unit tests to use the new service. The feedback focuses on simplifying the CloudFunctionsService by removing the redundant Injector and runInInjectionContext wrapper, enhancing type safety with generic typings for the callable helper, and improving test readability by formatting a long line in the spec file.
Refactored
AuthServiceto delegate Cloud Functions related logic (sessionLoginandprofileRefresh) to a new, dedicatedCloudFunctionsServicein order to improve code modularity. ReplacedHttpClientServiceandFunctionsdependencies withCloudFunctionsServiceinsideAuthService. Included unit tests for the new service and updatedAuthServicetests accordingly.PR created automatically by Jules for task 120037319741353196 started by @gino-m