Repository navigation
Conversation
When no options or reporters are used, values whose types cannot reach an Equal method, an interface, an unexported struct field, a map key which may be NaN, or a recursive type are now compared directly, following the same rules as compareAny but without path steps, cycle detection, option filtering, or the slice difference algorithm. Diff still builds its report with the full machinery. As suggested in google#353, this applies only when no option could apply. Comparing equal slices of 1000 small structs drops from 2051 allocations to none, and a 4KiB byte slice from 67 to none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)