Repository navigation
Add IgnoreMapKeys to cmpopts - #415
Open
ava-cassiopeia wants to merge 1 commit into
Open
ava-cassiopeia wants to merge 1 commit into
ava-cassiopeia wants to merge 1 commit into
Conversation
Author
|
Hmm, the test failure here seems unrelated to this change. Maybe something with the version of go that the macos check is pulling in..? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a convenience on top of
IgnoreMapEntries()that allows for uses like:I've wanted this now a few times while writing tests for work, and I figured I'd see what y'all think about adding this to the actual cmpopts package so I can avoid adding basically this same implementation to a common lib for my team's projects.
Some misc comments:
comparables, if desired.