Skip to content

refactor(model): replace custom stack_dict with Keras Concatenate layer - #109

Open
bogaktik wants to merge 1 commit into
google:mainfrom
bogaktik:fix-section-defining-base-model
Open

bogaktik wants to merge 1 commit into
google:mainfrom
bogaktik:fix-section-defining-base-model

Conversation

@bogaktik

Copy link
Copy Markdown

Summary of Changes:

  • Replaced the custom stack_dict function (which used native TF ops like tf.concat and tf.cast on symbolic tensors) with tf.keras.layers.Concatenate(axis=-1).
  • Updated input preprocessing to use a sorted list comprehension for deterministic ordering.
  • Updated normalizer.adapt() data handling to prevent tracking issues with symbolic tensors.

Why This Change is Needed:

  • In modern Keras, running native TensorFlow operations directly on symbolic KerasTensor placeholders inside a Functional API model definition can cause tracing and compatibility errors.
  • Using built-in Keras layers ensures the symbolic graph can track the inputs correctly.

Summary of Changes:
- Replaced the custom stack_dict function (which used native TF ops like tf.concat and tf.cast on symbolic tensors) with tf.keras.layers.Concatenate(axis=-1).
- Updated input preprocessing to use a sorted list comprehension for deterministic ordering.
- Updated normalizer.adapt() data handling to prevent tracking issues with symbolic tensors.

Why This Change is Needed:
- In modern Keras, running native TensorFlow operations directly on symbolic KerasTensor placeholders inside a Functional API model definition can cause tracing and compatibility errors.
- Using built-in Keras layers ensures the symbolic graph can track the inputs correctly.
@google-cla

google-cla Bot commented Oct 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bogaktik
bogaktik marked this pull request as draft November 1, 2026 23:52
@bogaktik
bogaktik marked this pull request as ready for review November 1, 2026 23:53
@bogaktik bogaktik closed this Nov 1, 2026
@bogaktik bogaktik reopened this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant