Repository navigation
Use the Emulator Preview for API 37+ system images - #418
Merged
Merged
Conversation
The Emulator Preview is published in the SDK repository as "emulators;latest" and "emulators;<build-id>", next to the regular "emulator" package. It requires features on the system images that are right now only available in the API 37+ system images. - For an API 37+ system image, a channel name (stable, canary, ...) now selects the latest Emulator Preview. Older images keep getting the regular emulator for that channel. The emulator is resolved per system image, so a regexp matching several images pairs each one with the emulator that fits it. - The interactive menu lists the Emulator Preview first for API 37+ images and does not offer it for older ones. - A locally supplied Emulator Preview zip is refused for an image below API 37. - The launcher no longer passes `-qemu -append panic=1` for the Emulator Preview, which already carries its own -append. - The Emulator Preview downloads as emulator-preview-<version>.zip, so it cannot be mistaken for a regular emulator of the same version already on disk. Also accept "beta" and "dev" as channel names for the emulator argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
emu-dockeruse the Emulator Preview for API 37+ system images.It is published in the SDK repository as
emulators;latestandemulators;<build-id>, alongside the regularemulatorpackage, andwas not picked up before.
The Emulator Preview requires features on the system images that are
right now only available in the API 37+ system images.
Changes
stable,canary, ...) selects the latest Emulator Preview. Older images keepgetting the regular emulator for that channel. No new keyword or flag:
the system image decides. The emulator is resolved per image, so a
regexp matching several images pairs each with the emulator that fits.
images, with the regular emulators still available below it. It is not
offered for older images.
Emulator Preview zip paired with an image below API 37 is refused.
-qemu -append panic=1is not passed for the EmulatorPreview, which already carries its own
-append; a second one makesthe emulator exit with "requires an argument".
emulator-preview-<version>.zip, so an existing regular emulator zipwith the same version is not reused in its place.
betaanddevare accepted as channel names for the emulatorargument, next to
stableandcanary.Testing
tests/test_emulator_preview.py(60 tests) covering packageparsing, per-image selection, menu filtering and ordering, zip
detection, the pairing check, the create flow, and the launcher
template.
pytest tests/ --ignore=tests/e2e: 112 passed.emu-docker create stable 'C google_apis x86_64$'(API 37.0): thechannel resolved to the Emulator Preview 37.1.3, and the container
booted to the launcher (boot completed in about 20 s, adb reports
SDK 37).