Repository navigation
chore(gooddata-api-client): regenerate against staging - #1868
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
==========================================
+ Coverage 84.19% 84.65% +0.46%
==========================================
Files 333 335 +2
Lines 23261 23696 +435
==========================================
+ Hits 19585 20061 +476
+ Misses 3676 3635 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Vojtasii
enabled auto-merge
October 12, 2026 10:37
Vojtasii
disabled auto-merge
October 12, 2026 10:37
Vojtasii
enabled auto-merge
October 12, 2026 10:37
…ient The OpenAPI generator aborts on a request body that declares no schema, which the removed AI chat endpoints on staging now do. Strip such bodies from the merged spec so the client can be regenerated; the per-API specs stay as the backend serves them. jira: F1-2929 risk: low
Full regeneration from the staging specs, bringing the client up to the current backend API, including MANAGE_VISUALIZATIONS. Adapts gooddata-sdk: label identifiers now also accept computedAttribute, so their type is passed explicitly, and workspace setting attributes are generated as JsonApiUserSettingInAttributes since the organization setting types diverged. The backend removed the legacy AI chat and search endpoints, so the ComputeService methods calling them now raise NotImplementedError instead of importing the deleted request models. jira: F1-2929 risk: high
Vojtasii
force-pushed
the
vto/manage-visualizations
branch
from
October 12, 2026 11:08
a48fd03 to
69269ec
Compare
hkad98
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes F1-2929.
A full regeneration of the API client from the staging specs. It brings in
MANAGE_VISUALIZATIONSalong with the rest of the current backend API.type="label"explicitly.ComputeServicemethods that called them keep their signatures but now raiseNotImplementedError, pointing to the AI Assistant API.build_exec_def_from_chat_resultandfor_created_visualizationare unchanged.Test plan
make format lintmake -C packages/gooddata-sdk type-checkandmake -C packages/gooddata-pandas type-checkTEST_ENVS=py314 make testfor each package:gooddata-pipelines(195),gooddata-dbt(8),gooddata-flexconnect(83) andgooddata-eval(1610) also passed against the same regenerated client.Risk
high:gooddata-api-clientis published, and the regeneration deletes or renames generated models, including the legacy chat and search models. Code that imports them directly will break. The SDK's public API is unchanged.Generated with Claude Code