Skip to content

chore(gooddata-api-client): regenerate against staging - #1868

Merged
Vojtasii merged 2 commits into
masterfrom
vto/manage-visualizations
Oct 12, 2026
Merged

Vojtasii merged 2 commits into
masterfrom
vto/manage-visualizations

Conversation

@Vojtasii

@Vojtasii Vojtasii commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes F1-2929.

A full regeneration of the API client from the staging specs. It brings in MANAGE_VISUALIZATIONS along with the rest of the current backend API.

  • Generator workaround (its own commit, so it can be reverted on its own): the removed AI chat endpoints declare a request body with no schema, which crashes the OpenAPI generator. The merged spec now drops such bodies. The per-API specs stay exactly as the backend serves them.
  • Regenerated client and SDK adaptation (one commit, so it builds on its own):
    • Label identifiers now pass type="label" explicitly.
    • Workspace settings use the regenerated attributes class.
    • The backend no longer serves the legacy AI chat and search endpoints. The ComputeService methods that called them keep their signatures but now raise NotImplementedError, pointing to the AI Assistant API.
    • build_exec_def_from_chat_result and for_created_visualization are unchanged.

Test plan

  • make format lint

  • make -C packages/gooddata-sdk type-check and make -C packages/gooddata-pandas type-check

  • TEST_ENVS=py314 make test for each package:

    Package Result
    gooddata-sdk 572 passed
    gooddata-pandas 347 passed
    gooddata-fdw 43 passed

    gooddata-pipelines (195), gooddata-dbt (8), gooddata-flexconnect (83) and gooddata-eval (1610) also passed against the same regenerated client.

Risk

high: gooddata-api-client is published, and the regeneration deletes or renames generated models, including the legacy chat and search models. Code that imports them directly will break. The SDK's public API is unchanged.

Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 15fbe744-607c-4743-a695-5955bfa62799

📥 Commits

Reviewing files that changed from the base of the PR and between 0d95295 and 3c2baff.


📒 Files selected for processing (7)
  • gooddata-api-client/gooddata_api_client/model/declarative_single_workspace_permission.py
  • gooddata-api-client/gooddata_api_client/model/declarative_workspace_hierarchy_permission.py
  • gooddata-api-client/gooddata_api_client/model/json_api_workspace_out_meta.py
  • gooddata-api-client/gooddata_api_client/model/user_management_workspace_permission_assignment.py
  • gooddata-api-client/gooddata_api_client/model/workspace_permission_assignment.py
  • schemas/gooddata-api-client.json
  • schemas/gooddata-metadata-client.json

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.



📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The client models and schemas now include MANAGE_VISUALIZATIONS in workspace permission values for declarative permissions, workspace metadata, and permission assignments.

Changes

Workspace permission enums

Layer / File(s) Summary
Add MANAGE_VISUALIZATIONS to permission enums
gooddata-api-client/gooddata_api_client/model/*, schemas/gooddata-api-client.json, schemas/gooddata-metadata-client.json
The client models and schemas include MANAGE_VISUALIZATIONS in the applicable direct and hierarchy permission values.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: hkad98


Merge Risk: ⚪ Minimal · up to 3c2ba

The client models and schemas accept the new workspace permission consistently. No merge-blocking issue is evident in the reviewed changes.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the client regeneration, which is part of the changeset. It does not mention the primary change, adding the MANAGE_VISUALIZATIONS permission, but it remains related and …

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the enum list,
One new permission joins the twist.
Direct and hierarchy values agree,
Schemas echo what models see.
The rabbit hops, then ticks the key.

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.65%. Comparing base (a1ae1c2) to head (69269ec).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1868      +/-   ##
==========================================
+ Coverage   84.19%   84.65%   +0.46%     
==========================================
  Files         333      335       +2     
  Lines       23261    23696     +435     
==========================================
+ Hits        19585    20061     +476     
+ Misses       3676     3635      -41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vojtasii
Vojtasii enabled auto-merge October 12, 2026 10:37
@Vojtasii
Vojtasii disabled auto-merge October 12, 2026 10:37
@Vojtasii
Vojtasii enabled auto-merge October 12, 2026 10:37
@Vojtasii Vojtasii changed the title feat(gooddata-api-client): add the MANAGE_VISUALIZATIONS permission chore(gooddata-api-client): regenerate against staging Oct 12, 2026
…ient

The OpenAPI generator aborts on a request body that declares no schema,
which the removed AI chat endpoints on staging now do. Strip such bodies
from the merged spec so the client can be regenerated; the per-API
specs stay as the backend serves them.

jira: F1-2929
risk: low
Full regeneration from the staging specs, bringing the client up to the
current backend API, including MANAGE_VISUALIZATIONS.

Adapts gooddata-sdk: label identifiers now also accept
computedAttribute, so their type is passed explicitly, and workspace
setting attributes are generated as JsonApiUserSettingInAttributes
since the organization setting types diverged. The backend removed the
legacy AI chat and search endpoints, so the ComputeService methods
calling them now raise NotImplementedError instead of importing the
deleted request models.

jira: F1-2929
risk: high
@Vojtasii
Vojtasii force-pushed the vto/manage-visualizations branch from a48fd03 to 69269ec Compare October 12, 2026 11:08
@Vojtasii
Vojtasii merged commit b3441dc into master Oct 12, 2026
14 checks passed
@Vojtasii
Vojtasii deleted the vto/manage-visualizations branch October 12, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants