fix: wait for CI checks to register before polling for completion - #40
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 344 344
=========================================
Hits 344 344 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gms1
force-pushed
the
fix/ci-wait-for-checks-20260911
branch
from
September 11, 2026 17:32
fac3289 to
8065048
Compare
When a PR is first created, GitHub Actions may not have registered any checks yet, so statusCheckRollup is empty. The completion loop interpreted an empty rollup as 'all checks passed' and merged prematurely. Added Phase 1: poll until at least one CI check appears in statusCheckRollup (5-minute timeout) before entering the Phase 2 completion loop.
gms1
force-pushed
the
fix/ci-wait-for-checks-20260911
branch
from
September 11, 2026 17:42
8065048 to
0ea6797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a PR is first created, GitHub Actions may not have registered any checks yet, so
statusCheckRollupis empty. The existing completion loop instep3_merge_pr()interpreted an empty rollup as "all checks passed" and merged prematurely.This caused PR #39 to be merged before CI checks had completed.
Fix
Added a Phase 1 polling loop that waits for at least one CI check to appear in
statusCheckRollup(5-minute timeout) before entering the Phase 2 completion loop. This ensures we never treat an empty check rollup as "all passed."Complements the earlier fix (PR #36) that handled false-negatives from skipped/neutral checks.
Changes
tools/bin/maintenance.sh: Added Phase 1 startup polling instep3_merge_pr()memory-bank/progress.md: Documented the fixmemory-bank/activeContext.md: Updated current work