Skip to content

fix: wait for CI checks to register before polling for completion - #40

Merged
gms1 merged 1 commit into
mainfrom
fix/ci-wait-for-checks-20260911
Sep 11, 2026
Merged

fix: wait for CI checks to register before polling for completion#40
gms1 merged 1 commit into
mainfrom
fix/ci-wait-for-checks-20260911

Conversation

@gms1

@gms1 gms1 commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Problem

When a PR is first created, GitHub Actions may not have registered any checks yet, so statusCheckRollup is empty. The existing completion loop in step3_merge_pr() interpreted an empty rollup as "all checks passed" and merged prematurely.

This caused PR #39 to be merged before CI checks had completed.

Fix

Added a Phase 1 polling loop that waits for at least one CI check to appear in statusCheckRollup (5-minute timeout) before entering the Phase 2 completion loop. This ensures we never treat an empty check rollup as "all passed."

Complements the earlier fix (PR #36) that handled false-negatives from skipped/neutral checks.

Changes

  • tools/bin/maintenance.sh: Added Phase 1 startup polling in step3_merge_pr()
  • memory-bank/progress.md: Documented the fix
  • memory-bank/activeContext.md: Updated current work

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7821680a-a09f-4fe5-9952-29dd6f8a1f3b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b0d9e4) to head (0ea6797).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          344       344           
=========================================
  Hits           344       344           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gms1
gms1 force-pushed the fix/ci-wait-for-checks-20260911 branch from fac3289 to 8065048 Compare September 11, 2026 17:32
When a PR is first created, GitHub Actions may not have registered
any checks yet, so statusCheckRollup is empty. The completion loop
interpreted an empty rollup as 'all checks passed' and merged
prematurely.

Added Phase 1: poll until at least one CI check appears in
statusCheckRollup (5-minute timeout) before entering the Phase 2
completion loop.
@gms1
gms1 force-pushed the fix/ci-wait-for-checks-20260911 branch from 8065048 to 0ea6797 Compare September 11, 2026 17:42
@gms1
gms1 merged commit afd86ec into main Sep 11, 2026
48 of 49 checks passed
@gms1
gms1 deleted the fix/ci-wait-for-checks-20260911 branch September 11, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant