Repository navigation
[UI] Fix scope bar text unreadable in dark mode - #26
Merged
Merged
Conversation
goneng
marked this pull request as ready for review
September 30, 2026 21:21
Draw the bar in dark colours under a dark appearance, so its buttons, whose titles already turn light there, stay readable. - Give the background gradient, border, separator and label colours a dark-appearance value, resolved when the bar draws - Keep every light-appearance value as it was - Test the background brightness under Aqua and Dark Aqua
goneng
force-pushed
the
dark-mode-scope-bar
branch
from
September 30, 2026 21:25
df5280d to
b3bfed7
Compare
goneng
changed the title
Collaborator
Author
|
@hannesa2, this fixes another UI bug that is related to dark-mode support - pls review |
hannesa2
approved these changes
Oct 3, 2026
|
Btw, I invited you here too |
Collaborator
Author
Thanks! - let's see if this fix works... (I will rebase/update the corresponding PR in GitX) |
hannesa2
pushed a commit
to gitx/gitx
that referenced
this pull request
Oct 3, 2026
Pick up the MGScopeBar fix that draws the bar above the file view in dark colours under a dark appearance (gitx/MGScopeBar#26). - Bump External/MGScopeBar to 2671a7e, which contains only that fix - Light mode is unchanged: the bar renders byte-identical to before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draw the bar in dark colours under a dark appearance. Until now it
always painted its light-grey gradient, while its buttons' titles turn
light in dark mode, so they were barely readable. In GitX this is the
Source / Blame / History bar above the file view.
Changes
dark-appearance value, resolved when the bar draws
Screenshots
Before (Dark Mode)
After (Dark Mode)
After (Light Mode)
Test plan
swift test: the Dark Aqua test fails before the change and passesafter it
separator) built from the old and new sources: light mode is
byte-identical, dark mode now shows a dark bar with readable titles