Remove the ready-for-review CI workaround - #4538
Open
henrymercer wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are narrowly scoped workflow/action updates that align with the PR description and don’t introduce functional code-path risk.
Review tier: Lite
Findings: None
What changed in this PR
Removes a prior GitHub Actions workaround that relied on the ready_for_review pull request event type by updating workflow triggers, and adjusts the internal PR-creation action to open automated PRs as non-drafts so CI can be triggered on initial creation.
Changes:
- Removed
ready_for_reviewfrompull_requesttrigger types in the build, Storybook, and CLI-test workflows. - Updated the
create-prGitHub Action to stop creating PRs as drafts (removed--draft).
| File | Description |
|---|---|
| .github/workflows/main.yml | Removes ready_for_review from the build workflow PR trigger types. |
| .github/workflows/cli-test.yml | Removes ready_for_review from the CLI-test workflow PR trigger types. |
| .github/workflows/build-storybook.yml | Removes ready_for_review from the Storybook workflow PR trigger types. |
| .github/actions/create-pr/action.yml | Stops creating automated PRs as drafts by removing --draft from gh pr create. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
ready_for_reviewfrom the build, Storybook, and CLI-test workflow triggers, and stop opening automated version-bump PRs as drafts.Maintainers can approve pending checks on PRs created with
GITHUB_TOKEN, so the draft-to-ready transition is no longer needed to trigger CI.