Raise bug-fix workflow credit cap and run pytest from PATH - #4508
Raise bug-fix workflow credit cap and run pytest from PATH#4508gyanu2507 wants to merge 2 commits into
Conversation
The agentic bug-fix run hit the 1K default and then failed trying ./.venv/bin/python (Permission denied). Give the workflow 2K credits, allow `python` as well as python3, and tell the agent to use PATH. Fixes github#4472
|
Thanks @gyanu2507 — a process heads-up. This one turns out to touch security-sensitive agentic-workflow infra: the change only takes effect once the compiled Two small design tweaks I'm weighing as I do, with rationale to follow in the finishing commit: keeping the credit cap as-is if the pytest-from-PATH fix removes the retry loop that caused the ~8-credit overrun, and keeping the bash allowlist at |
…fect PR github#4508 raised max-ai-credits to 2000 and added `python` to the bash allowlist in bug-fix.md, but never regenerated the compiled bug-fix.lock.yml — the artifact GitHub Actions actually runs. Both frontmatter-derived settings were therefore inert: the lock still pinned maxAiCredits to the 1000 default and allowed shell(python3) but not shell(python). (The prompt guidance was already live via {{#runtime-import}}.) Recompile with gh-aw v0.79.8 (the pinned compiler) to apply exactly: - agent + summary jobs' effective maxAiCredits: 1000 -> 2000 - harness allowlist: + shell(python) Dependabot's action SHA pins in the committed lock (actions/checkout v7.0.1, actions/setup-node v7.0.0) are preserved rather than reverted to the compiler's older baked-in defaults. No container digest, firewall domain, permission, or detection-job (400) change. Rework tests/test_bug_fix_workflow.py to assert the compiled lock (the real running artifact) for the cap and allowlist, and the runtime-imported Markdown for the pytest-PATH guidance, replacing the prior .md-only string checks that passed even while the running workflow was unchanged. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Sounds good. I'll leave the lockfile recompile and the credit / python allowlist tweaks to you. |
|
Maintainer note: I (@mnriem) pushed one agent-assisted commit (5c52420) to complete this PR. Disclosure: it was generated autonomously by GitHub Copilot (model: Claude Opus 4.8) and reviewed by me before pushing. The core gap was that I recompiled with the pinned I also reworked One judgment call for reviewers: keeping the cap at CI has not run on this push and will need a maintainer trigger. |
There was a problem hiding this comment.
🟢 Approval recommended
The source, generated workflow, and focused regression coverage consistently address both reported failures.
Pull request overview
Fixes #4472 by raising the bug-fix workflow’s credit budget and avoiding disallowed project-local Python executables.
Changes:
- Raises AI credit limit to 2000.
- Allows PATH-based
python,python3, andpytest. - Adds regression tests covering source and compiled workflow consistency.
File summaries
| File | Description |
|---|---|
.github/workflows/bug-fix.md |
Updates limits, allowlist, and test guidance. |
.github/workflows/bug-fix.lock.yml |
Regenerates the executable workflow. |
tests/test_bug_fix_workflow.py |
Guards the workflow configuration. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
The agentic bug-fix workflow hit the 1K default credit cap, then failed trying
./.venv/bin/python -m pytestwith Permission denied.This sets
max-ai-credits: 2000, allowspythonas well aspython3on the bash allowlist, and tells the agent to usepython3 -m pytest/pytestfrom PATH instead of a project venv interpreter.Testing
uv sync && uv run pytestuv run pytest tests/test_bug_fix_workflow.pyAI Disclosure
LLM-assisted implementation. I chose the issue, wrote the tests, and ran them locally.
Fixes #4472