-
Notifications
You must be signed in to change notification settings - Fork 12.1k
docs(templates): clarify /constitution's Sync Impact Report is temporary, review-only material (#4431) #4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mnriem
merged 3 commits into
github:main
from
chelsealong:fix/4431-constitution-sync-report-stacking
Sep 9, 2026
+28
−1
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| """Covers #4431: /constitution's Sync Impact Report must be documented as | ||
| temporary, review-only material rather than committed governance content. | ||
|
|
||
| The Outline step that produces the Sync Impact Report must state that it is | ||
| scratch material for human review and is expected to be removed before the | ||
| amended constitution file is committed. | ||
| """ | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| REPO_ROOT = Path(__file__).parent.parent | ||
| CONSTITUTION_TEMPLATE = REPO_ROOT / "templates" / "commands" / "constitution.md" | ||
|
|
||
|
|
||
| def test_sync_impact_report_step_documents_temporary_lifecycle(): | ||
| content = CONSTITUTION_TEMPLATE.read_text(encoding="utf-8") | ||
| step = content.split("Produce a Sync Impact Report", 1)[1].split("\n\n", 1)[0] | ||
| assert "temporary" in step.lower(), ( | ||
| "Step 4 must document that the Sync Impact Report is temporary, " | ||
| "review-only material, not governance content" | ||
| ) | ||
| assert "removed before" in step.lower() and "committed" in step.lower(), ( | ||
| "Step 4 must state the report is expected to be removed before the " | ||
| "amended constitution file is committed" | ||
| ) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.