fix: normalize semaphore capacity as decimal - #44
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
flyingrobots
marked this pull request as ready for review
September 22, 2026 15:59
9 of 18 tasks
doctor parsed a stored capacity with is_int and bash arithmetic, so a legacy 08 printed an arithmetic error, 010 compared as octal eight, and a value past 2^64 wrapped to a small number. It now uses valid_capacity, the same rule sem_read applies. Also: fix the duplicated Unreleased heading in CHANGELOG.md, run test/capacity.py in make test-docker, and note the doctor finding in README. Refs #35
main's record validation (#43) now decodes stored capacity in doctor and every read, so doctor keeps main's validate_record path, and valid_capacity delegates to record_uint instead of carrying a second decimal parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sem create gpu --capacity 01previously succeeded while emitting invalid JSON ("capacity":01). Capacity is now normalized as a positive decimal before storage, comparison, and serialization, with bounds of 1 through 9223372036854775807. Reads accept leading-zero metadata from older versions without rewriting it; malformed or out-of-range stored capacity fails withstore-read.Fixes #35.
Validation on published commit
5236944ef836cd50493c9d3042b126dd03bc7884:3507, 39 valid inputs, 31 invalid inputs, canonical storage checks, legacy metadata, unchanged refs after invalid input, and schema checks across lifecycle outputs.03produced exactly three winners; final slot state and doctor were checked.lint-and-testpassed.Earlier full runs encountered host-disk exhaustion and are excluded from validation. The unchanged commit passed its complete gate after space recovered. General stored-record validation remains in #33; partial multi-ref observation remains a separate correctness investigation in #38. This change does not claim a proof over all concurrency schedules.