Support Gantt intervals and Y-axis range slider metadata - #40
Merged
Merged
Conversation
ecarreras
approved these changes
Sep 24, 2026
giscebot
approved these changes
Sep 24, 2026
giscebot
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the public graph-processing contract and the related webclient consumers.
- Gantt parsing enforces exactly one X field plus one start and one end field, preserves record identity, and keeps duplicate task names as separate intervals.
- Optional selection/many2one grouping labels and empty/ungrouped results are covered.
y_range="slider"is opt-in and preserves the existing lineyAxisPropspayload while adding the renderer-facing metadata for line/bar graphs.- No dependency, schema, migration, or deployment coupling is introduced in this package.
- Validation: 142 Mamba examples pass on both Python 2.7 and Python 3.11;
git diff --checkpasses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the graph data contract with two XML capabilities:
y_range="slider"returns vertical range metadata for line and bar graphs while preserving the existing line-axis properties.graph type="gantt"returns one start/end interval per record, including record identity and optional grouping labels. Records with the same task name remain separate intervals.Existing graph definitions keep their current output when neither option is used. The graph processing API remains independent of the client renderer.
Validation
git diff --checkpass.Related to gisce/webclient#1110 and gisce/webclient#1240.
Dependencies
This PR has no upstream PR dependency and can merge independently. The ERP and client changes for gisce/webclient#1110 and gisce/webclient#1240 must consume a release containing this contract.