Repository navigation
Conversation
A custom inbound filter condition could only match its values. Give each condition an operator: matches, does_not_match, or a version comparison (gt, gte, lt, lte) on release. The operator defaults to matches, so a condition stored before the field existed keeps its meaning and reads back as matches. does_not_match compiles to Relay as "the field is present and does not match". Relay reads a missing field as no match, so a bare not would drop every event without a release or a client IP. A comparison compiles to Relay's release rule condition, which needs sentry-relay 0.10.1. The API only accepts it on release, with exactly one value that parses as a release with a version, since Relay never matches a comparison against a commit hash or a glob. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
shellmayr
marked this pull request as ready for review
October 14, 2026 14:23
vgrozdanic
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operatorfield:matches,does_not_match, or a release version comparisongt,gte,lt,lte. It defaults tomatches, so stored conditions keep their meaning and read back asmatches.does_not_matchcompiles to Relay as "the field is present and does not match". Relay reads a missing field as no match, so a barenotwould drop every event without a release or a client IP.releaserule condition, which needs sentry-relay 0.10.1 (ref: bump sentry-relay to 0.10.1 #126839). The API only accepts it onrelease, with exactly one value that parses as a release with a version.